fixed for utils.js/resolve #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanflorence
reviewed
Sep 5, 2019
| @@ -84,6 +84,10 @@ describe("resolve", () => { | |||
| expect(resolve("/groups?some=query", "/users?some=thing")).toEqual( | |||
| "/groups?some=query" | |||
| ); | |||
| expect(resolve("users/.././users", "/")).toEqual("/users"); | |||
| expect(resolve("some/.././users/../info/./address", "/users")).toEqual( | |||
| "/users/info/address" | |||
There was a problem hiding this comment.
wouldn't this be /info/address?
/users
some -> /users/some
.. -> /users
. -> /users
.. -> /
info -> /info
. -> /info
address -> /info/address
There was a problem hiding this comment.
thanks to review.
// equal this:
/users/some/.././users/../info/./address
// delete /xx/..:
/users/./info/./address
// then:
/users/info/addressjust like a cd operation:
So I wonder if I missed it.？
ryanflorence
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the test case:
so, i fixed it, and it's feedback
"/users"now.ps:
npm run testgot a error info just likeSecurityError: localStorage is not available for opaque origins, just add a jest config:"testURL": "http://localhost".