feature/RM-5931-Support-for-Bootstrapping-in-ServiceLocator#1037
Draft
MichaelKetting wants to merge 11 commits intodevelopfrom
Draft
feature/RM-5931-Support-for-Bootstrapping-in-ServiceLocator#1037MichaelKetting wants to merge 11 commits intodevelopfrom
MichaelKetting wants to merge 11 commits intodevelopfrom
Conversation
MichaelKetting
force-pushed
the
feature/RM-5931-Support-for-Bootstrapping-in-ServiceLocator
branch
4 times, most recently
from
eadcd51 to
fc4bad7
Compare
MichaelKetting
force-pushed
the
feature/RM-5931-Support-for-Bootstrapping-in-ServiceLocator
branch
from
2c93ad1 to
89329d7
Compare
TypePipe uses an older implementation of PEVerify lookup. In order to reduce development dependencies, removing this dependency from the unit tests unlinks this dependency chain.
… to break dependency on ITypeResolutionService. Note that since there is a dependency between type discovery configuration and type resolution, the relevant customizations must be dropped here. The configuration of the feature will be restored once ITypeDiscoveryService can be resolved via IoC container.
…sts and then the removal of ContextAwareTypeUtility
MichaelKetting
force-pushed
the
feature/RM-5931-Support-for-Bootstrapping-in-ServiceLocator
branch
from
89329d7 to
0d8cb2e
Compare
MichaelKetting
force-pushed
the
develop
branch
from
d221533 to
147fb1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://re-motion.atlassian.net/browse/RM-5931
DefaultServiceLocator.CreateWithBootstrappedServices()should be moved to development helpers. Production code should register defaults withBootstrapServiceConfiguration.RegisterAssemblyFilter-API toIBootstrapServiceConfigurationforIAssemblyLoaderFilter, that allows settingAddIgnoredAssembly,ShouldConsiderAssembly,ShouldIncludeAssemblyvia fluent API.RegisterSpecificRootAssemblies-API toIBootstrapServiceConfigurationforIRootAssemblyFinderthat sets upSpecificRootAssemblies. Creates fixedTypeDiscoveryServiceConfiguration.SpecificRootAssemblies.CreateRootAssemblyFinder(new FilteringAssemblyLoader(new LoadAllAssemblyLoaderFilter())). Remove the related Config-parts fromTypeDiscoveryServiceConfiguration(ModeandCreateTypeDiscoveryService).TypeDiscoveryServiceConfiguration.SpecificRootAssemblieswith fluent API by extendingRegisterSpecificRootAssemblieswith a fluent return type.RegisterLogging-API toIBootstrapServiceConfigurationforILogManager, accepting theILogManageras a parameter.ILogManagerfromIBootsrapSerivceConfigurationviaGetLogManager()extension method