Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle JRE 8 and use it - fix for incompatibility with newer Java versions #132

Closed
wants to merge 2 commits into from
Closed

Bundle JRE 8 and use it - fix for incompatibility with newer Java versions #132

wants to merge 2 commits into from

Conversation

mvorisek
Copy link

@mvorisek mvorisek commented Jun 7, 2020

fixes #96

notes:

  • maybe not all files needs to be bundles
  • still prefer to fix the compatibility with newer versions - then superseed this PR with PR that fixes it

@rdp
Copy link
Owner

rdp commented Jun 9, 2020 via email

@mvorisek
Copy link
Author

Hmm it's tricky to include a bundled. I might take a patch that updates jruby though! :)

@rdp yes, I also prefer it, would you be so kind to look at it? It is actually quite urgent, as without Java 9+ support, it won't work for most of the users. Thanks.

@rdp
Copy link
Owner

rdp commented Oct 16, 2020

@mvorisek
Copy link
Author

Please test https://github.com/rdp/screen-capture-recorder-to-video-windows-free/releases/tag/v0.12.11 thanks!

I run Setup.Screen.Capturer.Recorder.v0.12.11.exe and the issue is gone - tested with Java 12. Many thanks, @rdp / Roger!

@mvorisek mvorisek closed this Oct 16, 2020
@mvorisek mvorisek deleted the use_bundled_jre8 branch October 16, 2020 20:48
@rdp
Copy link
Owner

rdp commented Nov 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsupported Java version: 9
2 participants