Rspec proposal #52
Rspec proposal #52
Conversation
| describe "Array Plot Example" do | ||
| let(:file_path) { 'spec/tmp/array_plot.eps' } | ||
| let(:fixture_path) { 'spec/fixtures/plots/array_plot.eps' } | ||
|
|
There was a problem hiding this comment.
the idea of this test is rely on a pregenerated file when testing the whole integration
|
sounds reasonable, I could merge in a few days when it has quieted a bit,
or would you like to be a maintainer?
…On Wed, Nov 6, 2019 at 3:07 PM Favini ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/integration/arrtest_spec.rb
<#52 (comment)>:
> @@ -0,0 +1,44 @@
+describe "Array Plot Example" do
+ let(:file_path) { 'spec/tmp/array_plot.eps' }
+ let(:fixture_path) { 'spec/fixtures/plots/array_plot.eps' }
+
the idea of this test is rely on a pregenerated file when testing the
whole integration
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#52?email_source=notifications&email_token=AAADBUC6QOTKGW2D26OX6EDQSM52HA5CNFSM4JJ6LB32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKSJVZA#pullrequestreview-312777444>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUHUL2RPF5OMGDYELTLQSM52HANCNFSM4JJ6LB3Q>
.
|
|
Well, since this is the first proposal, I would sugest not to merge yet, and I will write the specs for everything and then we do just one merge, WDYT? About being maintainer, I could do that yes, I have deeply interest in this gem, but I have no hurry , I will only have time to actually use it next year :P |
|
let me know when you feel ready with it :) |
|
Sure, still a lot to cover. one thing though, I think I found a bug plot = Gnuplot::Plot.new
plot.title "my title"
plot.title "My NEW Title"
plot['title']this sounds like it should return if that is the case, I know where the fix should go and can prepare a parallel PR for that |
|
Sure.
…On Mon, Nov 25, 2019 at 2:00 AM Favini ***@***.***> wrote:
Sure, still a lot to cover. one thing though, I think I found a bug
plot = Gnuplot::Plot.new
plot.title "my title"
plot.title "My NEW Title"
plot['title'
this sounds like it should return My NEW Title while it is returning my
title still
if that is the case, I know where the fix should go and can prepare a
parallel PR for that
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#52?email_source=notifications&email_token=AAADBUCYPU4OSQ5HO5VXHADQVOH3XA5CNFSM4JJ6LB32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBUKPQ#issuecomment-558056766>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUFFTTGDU3HWGW23PLDQVOH3XANCNFSM4JJ6LB3Q>
.
|
|
Right now, the specs are covering 84% There is still a lot to cover (84% is not a real metric) Since I will go on vacation, I would merge this one and finish it in January Also, this can help with any refactoring comming |
|
Awesome, you rock! |
This is a proposal about using RSpec for unit testing
My idea, if you are up to it, would be to rewrite the tests in rspec format so that later I could split the gnuplot file to organize the code to facilitate contributions.
Here I am also adding simplecov to check spec code coverage