3.0.0 refactor project location #1492
Conversation
Will it also work for And as the Documents page contains the snapshots switch the |
|
I don't quite understand how to use it |
|
Like this (preferably in the redux actions): When the page loads, this information is then collected from the URL and put into the config reducer: https://github.com/rdmorganiser/rdmo/blob/3.0.0-refactor-project-location/rdmo/projects/assets/js/project/store/configureStore.js#L58 |
| const patterns = [ | ||
| /\/projects\/\d+\/(?<page>[a-z-]+)\/(?<pageId>\d+)\/(?<action>[a-z-]+)\/(?<actionId>\d+)[/]*$/, | ||
| /\/projects\/\d+\/(?<page>[a-z-]+)\/(?<pageId>\d+)\/(?<action>[a-z-]+)[/]*$/, | ||
| /\/projects\/\d+\/(?<page>[a-z-]+)\/(?<action>[a-z-]+)\/(?<actionId>\d+)[/]*$/, |
There was a problem hiding this comment.
I think we need this pattern also:
/\/projects\/\d+\/(?<page>[a-z-]+)\/(?<pageId>\d+)[/]*$/,
to reflect eg. /projects/1/snapshots/1/ for the documents page with a snapshot selected
This PR updates
rdmo/projects/assets/js/project/utils/location.jsto be more flexible.parseLocationandupdateLocationnow use both the same object as input/output:This should parse the following urls:
I suggest we use the
documentspage for current answers/views and snapshots andsnapshotsfor the snapshots. The highlighting of the sidebar can then just checkpage.