Skip to content

Conversation

@jochenklar
Copy link
Member

This PR is a small add-on to fix-management-ui-access and fixes the problem that legacy reviewers don't see the management panels in the interview. It also refactors the serializer (and the front-end) to use RDMO3 permission format. It's a small change, I hope its ok. (ProjectOverviewSerializer will be removed eventually, I guess.)

@jochenklar jochenklar self-assigned this Oct 21, 2025
@jochenklar jochenklar requested a review from MyPyDavid October 21, 2025 15:57
@jochenklar jochenklar added this to the RDMO 2.3.3 milestone Oct 21, 2025
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
Copy link
Member

we decided to name the permission management.view_management so I renamed it in here.

ok now I see that its actually used as a permission in ManagementView so I guess has_perm is the better idea. Maybe we should remove the can_ from the perms then:

management.view_management, management.upload_files, management.import_elements

maybe even management.upload_elements?

Then the naming is consistent and management and elements are kind of "fake" models, if you know what I mean.

Originally posted by @jochenklar in #1431 (comment)

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MyPyDavid
Copy link
Member

MyPyDavid commented Oct 30, 2025

we decided to name the permission management.view_management so I renamed it in here.

ok now I see that its actually used as a permission in ManagementView so I guess has_perm is the better idea. Maybe we should remove the can_ from the perms then:
management.view_management, management.upload_files, management.import_elements
maybe even management.upload_elements?
Then the naming is consistent and management and elements are kind of "fake" models, if you know what I mean.
Originally posted by @jochenklar in #1431 (comment)

from discussion, the front-end should get can_view_management, only the perm that is send from the backend needed to be fixed to management.view_management .

@jochenklar jochenklar merged commit 69385c7 into fix-management-ui-access Oct 30, 2025
18 checks passed
@jochenklar jochenklar deleted the fix-management-ui-access+interview-fixes branch October 30, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants