Skip to content

Fix resolveCondition action and reducer #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jochenklar merged 1 commit into from
May 16, 2025
Merged

Fix resolveCondition action and reducer #1356

jochenklar merged 1 commit into from
May 16, 2025

Conversation

@jochenklar
Copy link
Member

@jochenklar jochenklar commented May 15, 2025

This PR solves the problem with multiple questions with conditions per page. The bug was caused by

const setIndex = getState().interview.sets.indexOf(set)

because for the second element set would already have changed to the setIndex would be always -1. The fix is to use the reduce in a proper way.

@jochenklar jochenklar added this to the RDMO 2.3.1 milestone May 15, 2025
@jochenklar jochenklar requested a review from MyPyDavid May 15, 2025 14:45
@jochenklar jochenklar self-assigned this May 15, 2025
@MyPyDavid
Copy link
Member

MyPyDavid commented May 15, 2025

could reproduce it locally and this fixes it!

@jochenklar jochenklar merged commit 8290709 into 2.3.1 May 16, 2025
18 checks passed
@jochenklar jochenklar deleted the 2.3.1-fix-resolve-conditions branch May 16, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

@jochenklar jochenklar

Labels

None yet

Projects

None yet

Milestone

RDMO 2.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jochenklar @MyPyDavid