Openapi fixes #1298
Merged
Openapi fixes #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
MyPyDavid
approved these changes
Apr 7, 2025
Member
MyPyDavid
left a comment
MyPyDavid
left a comment
There was a problem hiding this comment.
thanks, I would keep it in the tests!
Member
|
Why is Line 53 in 045d221 If you replaced it completely with |
Member
thanks for spotting this @afuetterer! I'll make new PR and remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the tests for the
openapiendpoints again. I added the optional dependency to thedevsetup, because ... why not? We already test withallauthwhich is optional as well. The only drawback would be that we somehow mess up the settings withoutopenapi, but I am pretty sure that we will notice this using e.g. a test deployment.I changed the setup to use
drf_spectacular_sidecarto not use CDNs. (We just got rid of them ...).I also added a
loginfixture which we can use to force login users in the tests. TBD.