Add minimum required version to rdmo xml exports and check at import #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally validate it at import Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
MyPyDavid
commented
Feb 7, 2025
jochenklar
requested changes
Feb 17, 2025
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
jochenklar
reviewed
Feb 18, 2025
rdmo/core/xml.py
Outdated
| _('This RDMO XML file does not have a valid version number.'), | ||
| f'XML Version ({root_version}) is greater than RDMO instance version {rdmo_version}' | ||
| _('This RDMO XML file was created with a newer version of RDMO and cannot be imported.'), | ||
| _('Backwards compatibility is not supported for RDMO versions lower than 2.0.0.') |
Member
There was a problem hiding this comment.
I think "Backwards compatibility" is the wrong term here. It is more like forward compatibility. Actually the whole block makes no sense, since it will only be shipped with RDMO 2.3.0 which is > 2.0.0, right? (Did I get something wrong?)
Member
Author
There was a problem hiding this comment.
This is for the case when a RDMO 1.x tries to import an XML from RDMO 2.x.
It is maybe an edge-.. Ohw now I see 🙃, this code will not even exist in the RDMO 1.x 🤣
I'll remove this, thanks for noticing!
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #1205
This PR adds the field
requiredto the exported XML files. This field sets the minimal compatible RDMO version with which this file can be imported. A validation error will be raised when the RDMO version is lower than therequiredversion. When this field is missing, it is ignored.The field
versionis still used for version dependent conversions at import but not for compatibility validation.The minimal compatible version is defined in the setting
EXPORT_MIN_REQUIRED_VERSION.Motivation and Context
How has this been tested?
Screenshots (if appropriate)