RDMO 2.3.0 ⭐

.github/dependabot.yml

@@ -12,7 +12,6 @@ updates:
   - python
   - type:maintenance
   ignore:
-  - dependency-name: django-mptt # pinned, 0.15 requires Python >= 3.9
   - dependency-name: django
     update-types: [ "version-update:semver-major"] # ignore major for django
   groups:

.github/workflows/ci.yml

@@ -61,11 +61,11 @@ jobs:
       with:
         node-version: 18
         cache: npm
-    - run: npm ci && npm run build:prod
+    - run: npm ci && npm run build:dist
     # build the wheel
     - uses: actions/setup-python@v5
       with:
-        python-version: '3.12'
+        python-version: '3.13'
         cache: pip
     - run: |
         python -m pip install --upgrade pip build[uv] twine
@@ -100,7 +100,7 @@ jobs:
     runs-on: ubuntu-24.04
     strategy:
       matrix:
-        python-version: ['3.8', '3.12']
+        python-version: ['3.9', '3.13']
         db-backend: [mysql, postgres]
     steps:
     - uses: actions/checkout@v4
@@ -116,7 +116,7 @@ jobs:
         path: dist
     - name: Install Dependencies
       run: |
-        sudo apt-get update && sudo apt-get install --yes pandoc texlive-xetex librsvg2-bin
+        sudo apt-get update && sudo apt-get install --yes pandoc texlive-latex-base texlive-latex-extra texlive-luatex librsvg2-bin
         pandoc --version
         python -m pip install --upgrade pip
         python -m pip --version
@@ -138,14 +138,14 @@ jobs:
     - name: Run package status tests first
       run: |
         pytest rdmo/core/tests/test_package_status.py --nomigrations --verbose
-      if: matrix.python-version == '3.12' && matrix.db-backend == 'postgres'
+      if: matrix.python-version == '3.13' && matrix.db-backend == 'postgres'
     - name: Run Tests
       run: |
         pytest -p randomly -p no:cacheprovider --cov --reuse-db --numprocesses=auto --dist=loadscope
       env:
         GITHUB_DB_BACKEND: ${{ matrix.db-backend }}
     - name: Upload coverage data to coveralls.io
-      uses: coverallsapp/github-action@643bc377ffa44ace6394b2b5d0d3950076de9f63 # v2.3.0
+      uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2.3.6
       with:
         flag-name: '${{ matrix.db-backend }}: ${{ matrix.python-version }}'
         parallel: true
@@ -156,7 +156,7 @@ jobs:
     runs-on: ubuntu-24.04
     strategy:
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.13']
         db-backend: [postgres]
     steps:
     - uses: actions/checkout@v4
@@ -172,7 +172,7 @@ jobs:
         path: dist
     - name: Install Dependencies
       run: |
-        sudo apt-get update && sudo apt install --yes pandoc texlive-xetex librsvg2-bin
+        sudo apt-get update && sudo apt install --yes pandoc texlive-latex-base texlive-latex-extra texlive-luatex librsvg2-bin
         python -m pip install --upgrade pip
     - name: Install rdmo[postgres] from wheel and start postgresql
       run: |
@@ -197,7 +197,7 @@ jobs:
     - uses: actions/upload-artifact@v4
       with:
         name: screenshots
-        path: screenshots/*.png
+        path: screenshots/**/*.png
 
   coveralls:
     name: Indicate completion to coveralls
@@ -206,7 +206,7 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
     - name: Run Coveralls finish
-      uses: coverallsapp/github-action@643bc377ffa44ace6394b2b5d0d3950076de9f63 # v2.3.0
+      uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2.3.6
       with:
         parallel-finished: true
 
@@ -221,7 +221,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
           cache: pip
       - run: python -Im pip install --editable .[dev]
       - run: python -Ic 'import rdmo; print(rdmo.__version__)'
@@ -234,7 +234,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
           cache: pip
       - name: Download wheel
         uses: actions/download-artifact@v4

.gitignore

@@ -1,3 +1,9 @@
+__pycache__
+*.pyc
+*~
+*.swp
+.DS_Store
+
 testing/config/settings/local.py
 testing/log/
 .pytest*/
@@ -6,19 +12,12 @@ static_root
 media_root
 components_root
 
-docs/_build*
-
-__pycache__
-*.pyc
-*~
-*.swp
-.DS_Store
-.ruff_cache
-
 env
 env2
 env3
 
+Makefile
+
 .coverage
 .coverage.*
 htmlcov
@@ -32,12 +31,21 @@ dist
 .imdone/
 
 .pytest_cache
+.ruff_cache
 .on-save.json
 
 rdmo/management/static
 
-rdmo/projects/static/projects/js/projects.js
-rdmo/projects/static/projects/fonts
-rdmo/projects/static/projects/css/projects.css
+rdmo/core/static/core/js/base.js
+rdmo/core/static/core/js/base.js.LICENSE.txt
+rdmo/core/static/core/css/base.css
+rdmo/core/static/core/fonts
 
+rdmo/projects/static/projects/css/interview.css
+rdmo/projects/static/projects/css/projects.css
+rdmo/projects/static/projects/fonts/
+rdmo/projects/static/projects/js/interview.js
+rdmo/projects/static/projects/js/interview.js.LICENSE.txt
+rdmo/projects/static/projects/js/projects.js
+rdmo/projects/static/projects/js/projects.js.LICENSE.txt
 screenshots

.pre-commit-config.yaml

@@ -22,12 +22,12 @@ repos:
         exclude: \.dot$
       - id: debug-statements
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.9
+    rev: v0.9.9
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
   - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v9.12.0
+    rev: v9.21.0
     hooks:
       - id: eslint
         args: [--fix, --color]
@@ -36,7 +36,7 @@ repos:
           - eslint-plugin-react@7.37.0
           - react@18.3.1
   - repo: https://github.com/crate-ci/typos
-    rev: v1.26.0
+    rev: v1.30.0
     hooks:
     - id: typos
       exclude: |

CHANGELOG.md

@@ -1,5 +1,60 @@
 # Changelog
 
+## [RDMO 2.3.0](https://github.com/rdmorganiser/rdmo/compare/2.2.2...2.3.0) (Apr 11, 2025)
+
+* Add new interview interface based on React and Redux (#518)
+  * Text and Textarea widgets are now saved automatically
+  * Select dropdown widgets are now always searchable
+  * Show the unit of a question next to the answer field (#499)
+  * Tabs (e.g. Datasets) and single values can be reused in different projects.
+  * An "Apply to all" button can be used to paste information into all the tabs.
+  * Fix several issues regarding the interview (#501, #224, #1191)
+  * Display attributes in interview to admins, editors, reviewers (#224)
+  * Improve accessibility (#514, #1199)
+  * Remove custom widgets feature (remove `QUESTIONS_WIDGETS` from settings)
+  * Remove `PROJECT_QUESTIONS_AUTOSAVE` and `PROJECT_QUESTIONS_CYCLE_SETS` from settings.
+* Add the possibility to copy a project including all its values.
+* Add the option to make a project "visible" to all users (#152).
+  * Users interact with visible projects as if they would have the Guest role.
+  * With the new review feature, this can be used for templates for projects and datasets.
+  * Sites and groups can be used to restrict this behaviour.
+  * This feature is enabled by default via the `PROJECT_VISIBILITY` setting
+* Add a contact form modal to each question to contact support (#502)
+  * `PROJECT_CONTACT = True` and `PROJECT_CONTACT_RECIPIENTS = [list of email strings]`
+    enable this feature
+* Add signal handlers to automatically sync of project views and tasks (#345, #966, #1198)
+  * When `PROJECT_VIEWS_SYNC = True` or `PROJECT_TASKS_SYNC = True` is set, the views or
+    tasks for a project are automatically synchronized, depending on the
+    catalogs configured for them.
+* Add snapshot export plugins (which work like project export plugins)
+  * Add `PROJECT_SNAPSHOT_EXPORTS` to settings to register snapshot export plugins
+* Refactor the `accept` field for project import plugins
+  * The field is now a dict of the form `{'content_type': ['suffix']}`
+  * The old form should still work
+* Add `rdmo.accounts.middleware.TermsAndConditionsRedirectMiddleware'` (#141, #161)
+  * The (optional) middleware checks if a user has already confirmed the Terms of use.
+  * If not, users need to confirm to proceed.
+  * Optionally, when a confirmation renewal is required, the `ACCOUNT_TERMS_OF_USE_DATE = '2025-02-25'`
+    can be set to invalidate previous confirmations.
+* Add `rdmo-admin` script
+  * `rdmo-admin npm run [build:prod|build|watch]` can be used to build the front end
+  * `rdmo-admin build` can be used to build the python package
+  * `rdmo-admin messages [make|compile]` can be used create and compile the translations
+  * `rdmo-admin clean` can be used remove most files which are not version controlled
+* Add the support for custom markdown templates injected into help texts
+  * The code `{{ code }}` is replaced by a template specified in the `MARKDOWN_TEMPLATES` setting
+  * The `TEMPLATES_EXECUTE_SCRIPT_TAGS' setting controls whether Java script code can be executed.
+* Add minimum required version to RDMO XML exports (#1205).
+* Use the `uri` instead of `path` for attributes in the Django admin interface.
+* Fix a set of bugs where the maximum length of a field was not correctly validated by the API.
+* Use `lualatex` when using `Pandoc >= 3.0`.
+* Remove the `download_vendor_files` step of the setup
+  * Remove `VENDOR` and `VENDOR_CDN` from settings.
+* Remove `django-rest-swagger` dependency and add `drf-spectacular` as an optional dependency.
+  * Can be installed with `pip install rdmo[openapi]`.
+* Update Python and JavaScript dependencies.
+* Drop support for Python 3.8.
+
 ## [RDMO 2.2.2](https://github.com/rdmorganiser/rdmo/compare/2.2.1...2.2.2) (Oct 24, 2024)
 
 * Fix projects interface when using RDMO with a path (#1152)

CONTRIBUTING.md

@@ -31,7 +31,7 @@ If you decide to work on the issue yourself, please wait until you received some
 
 ## How to set up your development environment
 
-You need [Python 3.8+](https://www.python.org/downloads).
+You need [Python 3.9+](https://www.python.org/downloads).
 
 Install the package with development requirements:
 

NOTICE

@@ -79,33 +79,6 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 
-Django REST Swagger <https://github.com/marcgibbons/django-rest-swagger>
--------------------------------------------------------
-
-Copyright (c) 2013-2016, Marc Gibbons
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this
-   list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright notice,
-   this list of conditions and the following disclaimer in the documentation
-   and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
-ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-
 Twitter bootstrap <http://twitter.github.io/bootstrap/>
 -------------------------------------------------------
 

conftest.py

@@ -5,6 +5,7 @@
 import pytest
 
 from django.conf import settings
+from django.contrib.auth.models import User
 from django.core.management import call_command
 
 from rdmo.accounts.utils import set_group_permissions
@@ -34,7 +35,7 @@ def fixtures():
 
 
 @pytest.fixture(scope='session')
-def django_db_setup(django_db_setup, django_db_blocker, fixtures): # noqa: PT004 - pytest-django requires this name "django_db_setup"
+def django_db_setup(django_db_setup, django_db_blocker, fixtures):
     """Populate database with test data from fixtures directories."""
     with django_db_blocker.unblock():
         call_command('loaddata', *fixtures)
@@ -54,3 +55,23 @@ def files(settings, tmp_path):
 def json_data():
     json_file = Path(settings.BASE_DIR) / 'import' / 'catalogs.json'
     return {'elements': json.loads(json_file.read_text())}
+
+
+@pytest.fixture
+def login(client):
+    def force_login_user(username):
+        try:
+            user = User.objects.get(username=username)
+            client.force_login(user)
+        except User.DoesNotExist:
+            pass
+
+    return force_login_user
+
+
+@pytest.fixture
+def delete_all_objects():
+    def delete_all(*models):
+        for model in models:
+            model.objects.all().delete()
+    return delete_all