Task/View sync might be buggy

[jochenklar]

Description / Beschreibung

It you set catalogs for a view, views get only removed from projects when the catalog is actually removed from the view, not if it was not there in the first place (which might be the case for existing instances).

Also "no catalog" usually means all catalogs in RDMO, not no catalog.

Expected behaviour / Erwartetes Verhalten

Maybe the current behaviour is ok, TBD (@MyPyDavid @m6121 ?)

Steps to reproduce / Schritte zum Reproduzieren

1. A project has a view.
2. The view did not have the catalog of the project assigned, but we set another catalog.
3. The project still has the view.

Context / Kontext

I did not test for tasks or sites/groups, but assume the problem is the same (or not a problem at all).

[jochenklar]

The relevant query is here: https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/handlers/generic_handlers.py#L14 nope wrong idea

[m6121]

I would agree, that this is not expected. I think no selection is equivalent to all catalogs thus, also the change from no to one selection should remove the view in all other projects.

[MyPyDavid]

alright, I will look into this behavior.

Another thing is that the existing projects are currently not affected when enabling this feature. It only changes the projects after these signals are send and the handlers are called. To 'synchronize' all existing projects in instance would require extra functionality. Simplest would be via a manage.py management cli script, e.g. like sync_project_views and sync_project_tasks. What do you think about this @m6121?

[m6121]

Another thing is that the existing projects are currently not affected when enabling this feature. It only changes the projects after these signals are send and the handlers are called. To 'synchronize' all existing projects in instance would require extra functionality. Simplest would be via a manage.py management cli script, e.g. like sync_project_views and sync_project_tasks. What do you think about this @m6121?

Very good point! A management script would be great. We should then include it in the config/docs as a comment that when enabling the feature one has to run the script in order to enforce syncronization at the beginning.

[MyPyDavid]

this is maybe still needs a design decision.
Currently, when a project has a catalog that is unavailable it will be disregarded for syncing.
Is this a typical use-case or does the sync needs to go over all applicable projects anyway? @m6121

Originally posted by @MyPyDavid in #1362 (comment)

[jochenklar]

I think this behavior is fine, a project with an unavailable catalog should not be changed. Does it get changed if sites or groups of a view/task change?

[MyPyDavid]

ok, yes the signals that are handled for Task (and also View) are:

• m2m_changed for Task.catalogs.through
• m2m_changed for Task.sites.through
• m2m_changed for Task.groups.through
• post_save on the Task (actually only needed for when available was changed)
• post_save on the Project when the catalog was changed