bug in progress bar: the total is not updated when changing the answer to a question (which has conditions)

[MyPyDavid]

Description / Beschreibung

A question (radio button) at the start of the interview determines how many conditional questions will be part of the interview. Currently, when choosing any of the options, the total count of questions does not change. However, the navigation correctly displays greyed out and ungreyed questions. As soon as one on the conditional questions received an answer then the progress total is correctly updated again when changing the radio button at the start of the interview.

Context / Kontext

2.3.0

[jochenklar]

I will check when solving #1336 (I hope).

[jochenklar]

Fixed in RDMO 2.3.2.

[MyPyDavid]

I think there is still a bug in here. The question with options at the start can disable/enable some pages in the interview but these are not counted for the total when there are not yet any values on those pages.

[MyPyDavid]

In the discussion we found out that pages are only counted for the total number of questions (total in progress bar) when there is a single value on the page, so that initially, when the page is empty, those questions or not counted for total number.
Also, that it may be related to the pages having multiple conditions.
For testing purposes the SMP catalog was used. There is a question at the start about "smp/general/topic/application-class" that triggers the conditions on certain pages, which will be enable/disabled respectively.

[MyPyDavid]

I've tried something out in here #1399 but not yet sure if it would help..
Another thing is that the Section should be greyed out (eg similar to the Pages with show = False ) as well when there are no questions in there that can be answered.

[jochenklar]

I investigated a bit and the problem arises since the pages have is_collection = False. The code in https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/progress.py, in particular in count_questions does not take this into account.

In https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/progress.py#L209 resolved_sets is empty. We could check element.is_collection, but this would be faulty if the parent of element is hidden. Even then, this only counts the number of tabs/blocks. The same problem is in https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/progress.py#L250 where the actual questions are counted.

I am not sure how to fix this. My best idea is to make compute_sets (https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/progress.py#L42) more complicated and actually follow the tree of values and conditions.