Move SRCREV values from generic-srcrev.inc to individual recipes #349
Conversation
- Migrated SRCREV definitions from meta-middleware-generic-support/conf/include/generic-srcrev.inc - Added inline SRCREV values to 17 Bitbake recipes in meta-rdk - This improves recipe independence and maintainability - Each recipe now has its SRCREV defined locally Components updated: - crashupload, dcmd, libsyswrapper, libunpriv, rdkcertconfig - rdkversion, rfc, systimemgr (all variants), telemetry - bluetooth-mgr, dobby, memcapture, remotedebugger - rdmagent, xmidt-agent
There was a problem hiding this comment.
Pull Request Overview
This PR migrates SRCREV definitions from a centralized configuration file (generic-srcrev.inc) to individual Bitbake recipe files, improving recipe independence and maintainability. The change affects 17 recipes across multiple components including system utilities, container management, connectivity, and support tools.
Key changes:
- SRCREV values are now defined locally in each recipe file
- All SRCREV values match those previously in the centralized file
- Recipes can now be managed independently without relying on external SRCREV definitions
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xmidt-agent_git.bb | Added SRCREV for xmidt agent package |
| rdmagent.bb | Added SRCREV for RDM agent |
| remotedebugger.bb | Added SRCREV for remote debugger |
| memcapture_git.bb | Added SRCREV for memory capture tool |
| dobby.bb | Added SRCREV for Dobby container manager |
| bluetooth-mgr_git.bb | Added SRCREV for bluetooth manager |
| telemetry_git.bb | Added SRCREV for telemetry component |
| systimemgrinetrface_git.bb | Added SRCREV for system time manager interface |
| systimemgrfactory_git.bb | Added SRCREV for system time manager factory |
| systimemgr_git.bb | Added SRCREV for system time manager |
| rfc_git.bb | Added SRCREV for RFC component |
| rdkversion_1.0.bb | Added SRCREV for RDK version library |
| rdkcertconfig.bb | Added SRCREV for RDK certificate configuration |
| libunpriv.bb | Added SRCREV for libunpriv library |
| libsyswrapper.bb | Added SRCREV for syscall wrapper library |
| dcmd.bb | Added SRCREV for DCM agent |
| crashupload_git.bb | Added SRCREV for crash upload utility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| file://dobby_start_after_apparmor.patch \ | ||
| file://0001-RDKEMW-8825-enable-swap-limit.patch \ | ||
| " | ||
| SRCREV = "59381966b7251d46a28ef7897a290662ca6009cb" |
There was a problem hiding this comment.
Duplicate SRCREV definition. This recipe includes dobby.inc which already defines SRCREV = \"59381966b7251d46a28ef7897a290662ca6009cb\" on line 4. Adding a duplicate SRCREV in the main recipe file will override the included value and creates redundancy. Remove this line since the SRCREV is already defined in dobby.inc.
| SRCREV = "59381966b7251d46a28ef7897a290662ca6009cb" |
| PV ?= "1.0.0" | ||
| PR ?= "r0" | ||
|
|
||
| SRCREV ?= "d461bbd2fc8299f6e5056f488ff944e90142e9b6" |
There was a problem hiding this comment.
Duplicate SRCREV definition. Line 10 defines SRCREV with a weak default assignment (?=), and line 12 redefines it with a regular assignment. This creates redundancy and the line 12 assignment will always override line 10. Either remove line 10 or remove line 12, depending on whether a weak default is needed.
| SRCREV ?= "d461bbd2fc8299f6e5056f488ff944e90142e9b6" |
| PKG_VERSION = "0.5.15" | ||
|
|
||
| SRC_URI = "https://github.com/xmidt-org/xmidt-agent/releases/download/v${PKG_VERSION}/xmidt-agent_${PKG_VERSION}_rdk_armv7.ipk;name=xmidt-agent" | ||
| SRCREV = "a42eef93f5f129da6a25f1ce5386b2ee" |
There was a problem hiding this comment.
Inappropriate use of SRCREV. This recipe downloads a pre-built .ipk file from a GitHub release (line 7), not a git repository. SRCREV is only meaningful for git-based fetchers. The value "a42eef93f5f129da6a25f1ce5386b2ee" matches the md5sum on line 9, suggesting this was added by mistake. Remove this line as SRCREV serves no purpose for .ipk downloads.
| SRCREV = "a42eef93f5f129da6a25f1ce5386b2ee" |
|
Part of tracking issue #350 |
This file has been cleaned up to remove SRCREV values that have been migrated to individual recipe files in meta-rdk and meta-rdk-video. Removed entries (65 total): - 17 components migrated to meta-rdk recipes - 48 components migrated to meta-rdk-video recipes Remaining entries (8 components not yet migrated): - rdk-apparmor-profiles, rmfosal, rdkfw, rdkperf - hdmicecheader, memcr, starboard, rdkwindowmanager Added comprehensive header documentation explaining: - What was migrated and where - Links to related PRs and tracking issue - Clear separation of migrated vs remaining components Related PRs: - meta-rdk: rdkcentral/meta-rdk#349 - meta-rdk-video: rdkcentral/meta-rdk-video#2097 Closes: rdkcentral/meta-rdk#350
|
Update: Cleanup PR created - rdkcentral/meta-middleware-generic-support#2203 |
Summary
This PR migrates SRCREV definitions from
meta-middleware-generic-support/conf/include/generic-srcrev.incto individual Bitbake recipe files in meta-rdk.🔗 Multi-Repository Topic
This PR is part of a coordinated SRCREV migration across multiple repositories:
Changes
Components Updated
Testing
✅ All SRCREV values have been verified to match the values in generic-srcrev.inc exactly.
Benefits