Skip to content

new sdk transport invocation changes #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anjalimukundan merged 8 commits into from
Jun 11, 2025
Merged

new sdk transport invocation changes #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf50918
new sdk transport invocation changes
Nandana-NNR May 26, 2025
b3bacd3
lint fix
Nandana-NNR May 26, 2025
a20c8b4
invoker changes
Nandana-NNR Jun 9, 2025
effa614
build error fix
Nandana-NNR Jun 9, 2025
e9a5c86
build error fix
Nandana-NNR Jun 9, 2025
2b7d9c6
build error fix
Nandana-NNR Jun 9, 2025
3087fdb
build error fix
Nandana-NNR Jun 9, 2025
1e90de3
build error fix
Nandana-NNR Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/FireboltTransportInvoker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,12 @@
*/

import Transport from '@firebolt-js/sdk/dist/lib/Transport';
import { CONSTANTS } from './constant';
const logger = require('./utils/Logger')('FireboltTransportInvoker.js');

let invokeManager, invokeProvider;
let getInvoker;
try {
invokeManager = require('../plugins/FireboltExtensionInvoker').default.invokeManager;
invokeProvider = require('../plugins/FireboltExtensionInvoker').default.invokeProvider;
getInvoker = require('../plugins/FireboltExtensionInvoker').getInvoker;
} catch (err) {
logger.error(`Unable to import additional invoker - ${err.message}`);
logger.error(`Unable to import transport invoker for extension sdk - ${err.message}`);
}

let instance = null;

export default class FireboltTransportInvoker {
Expand All @@ -42,7 +37,7 @@ export default class FireboltTransportInvoker {
return instance;
}

async invoke(methodName, params, paramNamesArray, invoker = null) {
async invoke(methodName, params, paramNamesArray, sdk = null) {
const module = methodName.split('.')[0];
const method = methodName.split('.')[1];
if (paramNamesArray) {
Expand All @@ -52,10 +47,9 @@ export default class FireboltTransportInvoker {
// For each param, construct json using param name and value
jsonParams[paramNamesArray[i]] = params[i];
}
if (invoker == CONSTANTS.INVOKEPROVIDER) {
return await invokeProvider.send(module, method, jsonParams);
} else if (invoker == CONSTANTS.INVOKEMANAGER) {
return await invokeManager.send(module, method, jsonParams);
const invoker = getInvoker(sdk);
if (sdk && invoker) {
return await invoker.send(module, method, jsonParams);
} else {
return await Transport.send(module, method, jsonParams);
}
Expand Down
1 change: 1 addition & 0 deletions src/constant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export const CONSTANTS = {
defaultSDKs: defaultSdks,
INVOKEPROVIDER: 'invokeProvider',
INVOKEMANAGER: 'invokeManager',
INVOKEDSDK: 'invokeSDK',
additionalSDKs: [],
EXCLUDED_METHODS_FOR_MFOS: [],
PASCAL_CASED_MODULES: ['SecondScreen', 'SecureStorage', 'ClosedCaptions', 'AcknowledgeChallenge', 'DeveloperTools', 'LifecycleManagement', 'PinChallenge', 'UserGrants', 'VoiceGuidance'],
Expand Down