Add raw_touch() feature to also return pressure and timing data#34
Open
gitcnd wants to merge 3 commits intordagger:masterfrom
Open
Add raw_touch() feature to also return pressure and timing data#34gitcnd wants to merge 3 commits intordagger:masterfrom
gitcnd wants to merge 3 commits intordagger:masterfrom
Conversation
…ng debounce and spurious-event-rejection possible
Owner
|
Thanks for the effort you've put into enhancing the functionality! Your work could significantly benefit users. However, I don’t normally accept pull requests unless they are bug fixes or minor non-breaking updates. I believe that maintaining your changes in a separate branch would be the most appropriate. Given my current time constraints, having a dedicated branch for this specific implementation will help ensure that the core project remains easily maintainable while still offering this advanced option for users who need it. I’d be happy to add a link to your project from my repo to direct users to your work. |
…24, and recipe to make themImproved clock/time and file date handling
…24, and recipe to make them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a million for your awesome work.
I want to have "sliders", so I needed more than just "touch event detection", plus my board issues spurious events occasionally, so I've updated the touch-driver to return all the data needed to solve all my problems.
This update makes debounce and spurious-event-rejection possible, and allows polling for when we want to let users "drag things around" (in my case - it's a light-dimmer with an icon of a DJ slider control which they can move around).
This is also a test of whether or not PRs get merged. I'm planning a big update to the graphics code so we can use "rotate" properly (so you specify what rotation to use during init, and all graphics work on that orientation from then on). I'm not sure whether to contribute these new features (a lot of work), or to just do a local version for myself (so I can skip doing the ones I do not need - like polygons etc). No point doing lots of work if nobody wants it of course...