Skip to content

Update LCD.py #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update LCD.py #2

wants to merge 1 commit into from

Conversation

perspector
Copy link

Removed default display pins on line 48 (different between esp32 and esp8266), set default columns to 8 in line 49, and fixed a typo (changed lines to rows) on line 60.

Removed default display pins on line 48 (different between esp32 and esp8266), set default columns to 8 in line 49, and fixed a typo (changed lines to rows) on line 60.
@rdagger
Copy link
Owner

rdagger commented Oct 27, 2024

Thank you for your pull request. I see you've adjusted some of the default constructor parameters, likely to better suit your use case. However, because these parameters are only defaults, they’re designed to work for a broad range of users and can be easily overridden when initializing the library. Changing them in the core code could impact other users without adding significant benefit.

The typo in the comments regarding lines is a good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants