Skip to content

Fix Vite extension #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix Vite extension #457

merged 1 commit into from
Feb 26, 2025

Conversation

daniser
Copy link
Contributor

@daniser daniser commented Feb 26, 2025

New Vite extension (#435) have several problems:

  • its output is not marked as html safe, so it mangles html tags making extension unusable;
  • you can't pass second argument ($buildDirectory) while calling Vite;
  • some parts of implementation makes little sense.

This PR fixes all these issues and simplifies code.

@barryvdh barryvdh merged commit 8520b08 into rcrowe:master Feb 26, 2025
13 checks passed
@daniser daniser deleted the fix/vite-ext branch February 26, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniser @barryvdh