Add OGP tags for user profiles #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcfxb
requested changes
Jan 9, 2022
src/web/services/user/profile.rs
Outdated
|
|
||
| let mut tags = Tags::default(); | ||
| tags.title = page_title.clone(); | ||
| tags.url = format!("/user/{}", id); |
There was a problem hiding this comment.
Does this URL work without the rcos.io domain at the beginning of it?
There was a problem hiding this comment.
I think it does work but I'll go ahead and change it to the same way it is done for meetings (request URI) for consistency.
src/web/services/user/profile.rs
Outdated
| @@ -87,7 +88,7 @@ async fn profile( | |||
| // Return early if there was an error. | |||
| // Otherwise we can go forward and check for the user's membership in the RCOS | |||
| // Discord server. | |||
| return template.in_page(&req, page_title).await; | |||
| return template.in_page(&req, page_title.clone()).await; | |||
There was a problem hiding this comment.
Why clone here? Ownership will not get moved after returning. Does the compiler error otherwise?
There was a problem hiding this comment.
I was having some issues with ownership and put that while debugging. After thinking about it, it seems unnecessary since it returns so I'll remove.
vcfxb
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds OGP tags for profile pages. Here is an example of what it might look like on discord.
Coordinator and Project Lead are conditionally shown if that user happens to be those for that semester.