Small fixes #179

bepvte · 2021-10-05T20:50:00Z

Small nitpicky changes that I had sitting around from work on the discord part that I switched away from

Use library way of finding real IP (we keep it in a wrapper in case we need to change to a different more secure method)
Reduce config format confusion (discord recommends keeping IDs as strings usually, and they are strings elsewhere in the config)
Remove nativetls support from reqwest, speeding up compile

Discord usually stores and processes its IDs in string formats anyway

We dont use it anywhere but reqwest

bepvte · 2021-10-05T20:52:03Z

src/web/csrf.rs

-        })
-        .ok_or(TelescopeError::IpExtractionError)
+    req.connection_info()
+              .realip_remote_addr()


https://docs.rs/actix-web/3.0.0-beta.1/actix_web/dev/struct.ConnectionInfo.html#method.realip_remote_addr

vcfxb

Minor concern about changes to the XFF header handling but I think we should be fine!

bepvte added 3 commits September 30, 2021 16:55

Switch to actix-web way of getting real ip

4ae571e

Make the guild ID a string like other id in config

c0448dd

Discord usually stores and processes its IDs in string formats anyway

Speed up compile by removing nativetls

a8442b1

We dont use it anywhere but reqwest

bepvte commented Oct 5, 2021

View reviewed changes

vcfxb approved these changes Oct 5, 2021

View reviewed changes

vcfxb merged commit e53b685 into rcos:master Oct 5, 2021

bepvte deleted the bep-small-fixes-1 branch October 5, 2021 21:02

Provide feedback