Skip to content

Improve logging when exceptions are handled by ClientToServerChannelH… #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
israelcolomer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve logging when exceptions are handled by ClientToServerChannelH… #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
490e0f7
Improve logging when exceptions are handled by ClientToServerChannelH…
israelcolomer Oct 19, 2016
459e9d8
Only when errorResponseConstructor couldn't handle it..
israelcolomer Oct 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/foundation/stack/datamill/http/impl/ClientToServerChannelHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ private void processRequest(ChannelHandlerContext context, HttpRequest originalR
logger.debug("Error occurred handling request, invoking application error handler");
return errorResponse.onErrorResumeNext(Observable.just(null));
}
else {
logger.debug("Error occurred handling request", throwable);
}
} else {
logger.debug("Error occurred handling request - no application error handler was available to handle it - {}", throwable);
}
Expand Down