Added cancelOnLeave option #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @m424m, thanks for your contribution. I think I will change the option name to mouseCancelOnLeave or so, to make it more explicit. I think I will publish it on Sunday. |
| eventAdd(container, 'mouseup', eventDragStop) | ||
| eventAdd(options.cancelOnLeave ? container : window, 'mousemove', eventDrag) | ||
| if (options.cancelOnLeave) eventAdd(container, 'mouseleave', eventDragStop) | ||
| eventAdd(window, 'mouseup', eventDragStop) |
There was a problem hiding this comment.
Wondering if this change is intentional? this is changing the existing behavior as the mouseup event now binding to window regardless of options.cancelOnLeave option, which previously bind to the container.
Some of our use case which manually handles tap (mouseup) on the slide and programmatically calls slider.next/slider.prev (v5), and this behavior breaks the use case as the timing for eventDragStop changes (window vs container).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
mousemoveevent is only fired while the pointer is inside the container, and the drag gesture being suddenly cancelled feels a little anticlimactic. I added thecancelOnLeaveoption which allows to override this behavior.