bug fix last slide not visible when loop true #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcbyr could you please consider merging this PR? |
|
Thanks for your PR. But it doesn't work. Even if the last slide is displayed correctly, the first slide will then disappear. The problem has only been relocated. Since the slider does not duplicate slides, it probably does not make sense to activate the loop if there are too few slides. In this case there is enough space in the viewport to display all slides anyway. |
|
What you said is true, but I want the loop because the slides in the slider are dynamic. so I want this functionality. Can you please see if you can add this scenario ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#352