Added support for drag handles that contain nested elements. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the element that is marked with the drag handle class.
This upgrades the 'drag handle' feature to work with handles that contain nested elements such as the following:
<div
ng-repeat="..."
dnd-draggable="item"
dnd-handle-class="drag-handle"
>
<span
class="drag-handle"
> <!-- This is the drag handle. -->
<i class="fa fa-reorder"></i> <!-- This is the clicked element -->
</span>
...
</div>
…erty to determine if there is any ancestor remaining to be checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to walk up the DOM from the dragged element to search for the element that is marked with the drag handle class.
This upgrades the 'drag handle' feature to work with handles that contain nested elements such as the following: