Skip to content

Commit

Permalink
Grammer & Style Tweaks as per feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
gaurish committed Nov 13, 2015
1 parent 06adda5 commit a1ca490
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion guides/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
* New section in Testing Guide - Testing Time Sensitive Code
* New section in Testing Guide - Testing Time-Dependent Code

*Gaurish Sharma*

* Add code of conduct to contributing guide
Expand Down
6 changes: 3 additions & 3 deletions guides/source/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -1237,8 +1237,8 @@ Testing Time-Dependent Code
---------------------------
You might have code in your rails app, that is time sensitive. For example,
you want to give some gifts to users but only after they have been a member for 1month
which is calculated from their activation date. to test such business logic in your tests
you want to give some gifts to users but only after they have been a member for month
which is calculated from their activation date. To test such business logic in your tests
you will need to time travel in your tests.
Fortunately, Rails provides inbuild helper methods which allow you time travel in your test code,
Expand All @@ -1251,7 +1251,7 @@ Here is an example using [`travel_to`](http://api.rubyonrails.org/classes/Active
user = User.create(name: 'Gaurish', activation_date: Date.new(2004, 10, 24))
assert_not user.applicable_for_gifting? # `activation_date` => Wed, 24 Nov 2004
travel_to Date.new(2004, 11, 24) do
assert_equal Date.new(2004, 10, 24), user.activation_date # inside the trave_to block `Date.current` is mocked
assert_equal Date.new(2004, 10, 24), user.activation_date # inside the travel_to block `Date.current` is mocked
assert user.applicable_for_gifting? # `activation_date` => Sun, 24 Oct 2004
end
assert_equal Date.new(2004, 10, 24), user.activation_date # Outside the block, changed are undone
Expand Down

0 comments on commit a1ca490

Please sign in to comment.