-
Notifications
You must be signed in to change notification settings - Fork 91
Implementation - Settlement API, issue, cancel, send/ resend notification, delete, edit methods #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… added in invoice file and new api i.e. settlement api
…ssue, edit method added in invoice file and new api i.e. settlement api
|
@varunajmera0 Thanks for the Pull Request! We're getting this reviewed internally. 🔜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things need addressing, please check below.
Request to please add tests for new endpoints, for invoice you can just add new test cases in TestClientInvoice.py. For settlements request to do it same way by adding new test class.
…point and test file is created for settlement and test function is done in test invoice file
…point and test file is created for settlement and test function is done in test invoice file
…ncel, delete and issue endpoint and test file is created for settlement and test function is done in test invoice file
| - Create payment link | ||
|
|
||
| ```py | ||
| DATA = {"customer": { "name": "Varun Test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix formatting and sample data in all these snippets.
| invoice_id : Id for delete the invoice | ||
| data : Dictionary having keys using which invoice have to be updated | ||
| Returns: | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too verbose comment in code, can just say returns json for invoice entity and link to existing docs containing this sample.
|
Merging this now. Thanks a lot @varunajmera0 👍 |
|
Thanks @varunajmera0 💯 |
|
thanks, @jitendra-1217 @amitmahbubani @captn3m0 |
Here is my implementation:-
I updated the invoice file methods like -
You can use these methods on payment link.
A new Settlement API is done.