Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new icons #2410

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add new icons #2410

wants to merge 5 commits into from
+2,842 −4

Conversation

anuraghazra
Copy link
Member

@anuraghazra anuraghazra commented Nov 11, 2024 •
edited
Loading

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eba230c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@saurabhdaware
Copy link
Member

can you check the chromatic publish action on this PR? not able to see the published version

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 12, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eba230c:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Nov 12, 2024 •
edited
Loading

Bundle Size Report

No bundle size changes detected.

Generated by 🚫 dangerJS against eba230c

@saurabhdaware
Copy link
Member

https://razorpay.slack.com/archives/C074E2N774G/p1731318190401059?thread_ts=1731053020.627619&cid=C074E2N774G

One comment. Rest everything looks good

@saurabhdaware
Copy link
Member

Add changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar chaitanyadeorukhkar is a code owner

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

@saurabhdaware saurabhdaware Awaiting requested review from saurabhdaware saurabhdaware is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraghazra @saurabhdaware @rzpcibot