refactor: deprecate billing_id in checkout RPCs #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark billing_id as deprecated in all checkout request messages: - CreateCheckoutRequest - ListCheckoutsRequest - GetCheckoutRequest - DelegatedCheckoutRequest (admin) Backend will infer billing_id from org_id automatically. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Mark org_id as deprecated in GetCheckoutRequest since checkout can be fetched by ID alone without needing organization context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
billing_idas deprecated in all checkout-related request messages. Backend will automatically inferbilling_idfromorg_id.Changes
CreateCheckoutRequest- Markbilling_idas deprecatedListCheckoutsRequest- Markbilling_idas deprecatedGetCheckoutRequest- Markbilling_idas deprecatedDelegatedCheckoutRequest(admin) - Markbilling_idas deprecatedRationale
Each organization has exactly one billing account. Requiring clients to pass both
org_idandbilling_idis redundant.Backward Compatibility
✅ No breaking changes - All existing clients continue to work:
ignore_empty: truefor gradual migrationRelated
Backend PR: [Frontier PR link]