Skip to content

ci: Change develop sync flow #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented May 8, 2025

Description

ci: Change the sync flow for the develop branch.

The daily auto sync develop with main workflow which I proposed earlier can be replaced with a simple workflow which raises a sync PR only when anything is merged to main. This will eliminate the unnecessary runs daily which most of the time will not be needed. It raises a PR and can not auto merge main into develop as it has protection rules enabled and rejects direct merges.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Will be tested after the PR is merged.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

[Add screenshots here]

Related Issues

[Link any related issues here using #issue-number]

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apsara ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 6:58am

@paanSinghCoder paanSinghCoder changed the base branch from develop to main May 8, 2025 06:57
@paanSinghCoder paanSinghCoder changed the title Chore/change develop sync flow ci: Change develop sync flow May 8, 2025
@paanSinghCoder paanSinghCoder marked this pull request as draft May 8, 2025 07:38
@rohilsurana rohilsurana requested a review from Copilot May 12, 2025 09:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow for the develop branch by replacing the daily schedule trigger with one that fires when a PR is merged to main.

  • Removed the scheduled workflow and added a pull_request trigger with a condition to run only when a PR is merged into main.
  • Introduced a sync check step and a subsequent process to create a sync branch and open a PR if develop is out of date with main.

fi

- name: Create sync branch and PR
Copy link
Preview

Copilot AI May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow does not explicitly check out the develop branch before creating the sync branch. This might result in the sync branch being created from an unintended branch. Consider adding an explicit checkout step for develop before creating and merging into the sync branch.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant