[rshapes] Fix DrawRectangleRoundedLines()#5992
Merged
Merged
Conversation
In raysan5#5980 a bug was introduced for `DrawRectangleRoundedLines()`. `DrawRectangleRoundedLines()` previously assumed that `DrawRectangleRoundedLinesEx()` uses `RL_LINES` when line thickness is 1 (which is no longer true, it now uses `RL_QUADS` or `RL_TRIANGLES`.) I copy/pasted the previous `DrawRectangleRoundedLinesEx()` implementation and trimmed it down (since now the line thickness is always 1), so now `DrawRectangleRoundedLines()` uses `RL_LINES`. This makes it consistent with all other `Draw*Lines()` functions, which use `RL_LINES`.
Owner
|
@MatthewRoush thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5980 a bug was introduced for
DrawRectangleRoundedLines().DrawRectangleRoundedLines()previously assumed thatDrawRectangleRoundedLinesEx()usesRL_LINESwhen line thickness is 1 (which is no longer true, it now usesRL_QUADSorRL_TRIANGLES.)I copy/pasted the previous
DrawRectangleRoundedLinesEx()implementation and trimmed it down (since now the line thickness is always 1), so nowDrawRectangleRoundedLines()usesRL_LINES. This makes it consistent with all otherDraw*Lines()functions, which useRL_LINES.