Change sanitization check for ExportDataAsCode
#3837
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I opted to use `isalnum` function since it should handle most cases. It cannot however handle cases of files beginning with numbers.
Contributor
|
It is good to use isalnum. Please see #3814 (comment) and subsequent comments for covering all cases and providing a utility function for this. I still have no idea why capitalization is needed. I think it is a misplaced application of the preprocessor identifier capitalization practice. That should be no issue in this use-case. |
raysan5
reviewed
Feb 26, 2024
Owner
|
@lauchimoon Thank you very much for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to use
isalnumfunction since it should handle most cases. It cannot however handle cases of files beginning with numbers.