Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shaders path #3316

Closed
wants to merge 1 commit into from
Closed

Fix shaders path #3316

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2023

Adds the ApplicationDirectory path to the shader files path of the shaders_mesh_instancing.c (R71-R73) example.

Fixes #3315.

Very likely also fixes "REVIEW: Example: models_mesh_instancing. Not working properly on web, issues with the shader but ONLY when uploade to GitHub, it works as expected locally." from #2952.

Edit: added example reference and line marks.

@raysan5
Copy link
Owner

raysan5 commented Sep 15, 2023

@ubkp I'm afraid this is not the issue. If that was the issue, no shaders example would work, all follow the same loading pattern.

I just tried the example on desktop and web (locally) and it works as expected with latest raylib at this same moment.

Attaching my local compilation: shaders_mesh_instancing.zip

I vaguely remember I already faced this issue in the past but it's really weird, it works ok locally but once uploaded to GitHub it just stops working, issue is related to shader line-breaks (LF vs CR LF) but I don't know why it only fails for the specific shaders used in this example.

@raysan5 raysan5 closed this Sep 15, 2023
@ghost
Copy link
Author

ghost commented Sep 15, 2023

@raysan5 Yes, you're right. I've jumped into the first thing that appeared to be a solution. I should review these more carefully. My bad, sorry.

@ghost ghost deleted the fix/example-shaders branch September 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rmodels] DrawMeshInstanced() is not working
1 participant