[build] `make install` doesn't work on RPI3

[trikko]

Issue description

make PLATFORM=PLATFORM_RPI

result:

ar rcs ../src/libraylib.a rcore.o rshapes.o rtextures.o rtext.o utils.o rmodels.o raudio.o
raylib static library generated (libraylib.a) in ../src!

sudo make install

result:

mkdir --parents --verbose /usr/local/lib
mkdir --parents --verbose /usr/local/include
cp --update --verbose /home/pi/src/raylib/libraylib.a /usr/local/lib/libraylib.a
cp: impossibile eseguire stat di '/home/pi/src/raylib/libraylib.a': File o directory non esistente
make: *** [Makefile:629: install] Error 1

It tries to copy /home/pi/src/raylib/libraylib.a instead of /home/pi/src/raylib/src/libraylib.a

Environment

rpi3

[raysan5]

This is very weird, I'm looking at the Makefile and I can't find the issue. libraylib.a is actually generated in $(RAYLIB_RELEASE_PATH)/libraylib.a, so, the path should be correct. The only way to modify it is defining a custom RAYLIB_RELEASE_PATH...

[raysan5]

Just noted this code in line 150:

# RAYLIB_SRC_PATH adjustment for different platforms.
# If using GNU make, we can get the full path to the top of the tree. Windows? BSD?
# Required for ldconfig or other tools that do not perform path expansion.
ifeq ($(PLATFORM),PLATFORM_DESKTOP)
    ifeq ($(PLATFORM_OS),LINUX)
        RAYLIB_PREFIX  ?= ..
        RAYLIB_SRC_PATH = $(realpath $(RAYLIB_PREFIX))
    endif
endif

Could it, maybe, be executed before assigning RAYLIB_RELEASE_PATH ?= $(RAYLIB_SRC_PATH)???

EDIT: If that's the case, then the issue is platform dependant and probably this code should be removed...

[colesnicov]

RPI 2 Model B
OS: RapiOS (Buster)
GL Driver: FULL_KMS

I followed the wiki instructions:
cd src && make PLATFORM = PLATFORM_RPI
and i have same errors:

sudo make install
mkdir --parents --verbose /usr/local/lib
mkdir --parents --verbose /usr/local/include
cp --update --verbose /home/pi/raylib/libraylib.a /usr/local/lib/libraylib.a
cp: cannot stat '/home/pi/raylib/libraylib.a': No such file or directory
make: *** [Makefile:635: install] Error 1

[colesnicov]

NO, it is bad too.

Just noted this code in line 150:

# RAYLIB_SRC_PATH adjustment for different platforms.
# If using GNU make, we can get the full path to the top of the tree. Windows? BSD?
# Required for ldconfig or other tools that do not perform path expansion.
ifeq ($(PLATFORM),PLATFORM_DESKTOP)
    ifeq ($(PLATFORM_OS),LINUX)
        RAYLIB_PREFIX  ?= ..
        RAYLIB_SRC_PATH = $(realpath $(RAYLIB_PREFIX))
    endif
endif

Could it, maybe, be executed before assigning RAYLIB_RELEASE_PATH ?= $(RAYLIB_SRC_PATH)???

EDIT: If that's the case, then the issue is platform dependant and probably this code should be removed...

NO, it is bad too.

[raysan5]

Any Linux expert in the room?

[wereii]

So, the problem is in that the setting PLATFORM=PLATFORM_RPI will cause this ifeq branch to not be taken and the RAYLIB_PREFIX and RAYLIB_SRC_PATH are not changed thru the realpath as would happen on other non-rpi Linux.

What this causes is that when running build make PLATFORM=PLATFORM_RPI the paths will be different then when running make install without the platform setting.

The proposed PR of mine would fix this so the paths are same both for RPi and Linux, eg. generate the final .a into root raylib not into raylib/src.

[raysan5]

@wereii I'm generating libraylib.a in raylib/src for other platforms and that's the expected behaviour also on Linux/RPI.