Skip to content

change from unstable cargo feature to RUSTFLAGS #369

@nikomatsakis

Description

@nikomatsakis

So we encountered some problems that people are relying on things gated by "feature=unstable" (e.g., #364). This isn't really surprising. I was thinking that a better approach would be use a cfg flag that is not tied to a feature. Therefore, in order to build Rayon with experimental features, you would have to do:

RUSTFLAGS='--cfg rayon_unstable' cargo build

This flag will propagate to the rayon create, which will then include unstable features. This has the same "infectious" property that Rust nightly builds do: you can't use an unstable feature in your crate without the top-level crate being forced to acknowledge it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions