Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sh file, commands/browsing/open-multiple-websites-on-safari.template.sh #960

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ystknsh
Copy link
Contributor

@ystknsh ystknsh commented Aug 29, 2024

Description

Add a new script command

  • Filename: open-multiple-websites-on-safari.sh
  • Title: Open Multiple Websites on Safari
  • Description: Open multiple websites on Safari using list of URLs

Type of change

  • New script command

Screenshot

NA
This script opens the Safari app with multiple websites in separate tabs.

Dependencies / Requirements

NA

Checklist

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ystknsh 👋,
thanks for your contribution to our repository.

In order to have your PR merged, you will need to rename your file adding .template as a suffix. This is due because you depend on extra configuration that should be done by the user, therefore, the .template is required.

How it is
commands/browsing/open-multiple-websites-on-safari.sh

How it should be
commands/browsing/open-multiple-websites-on-safari.template.sh

Please, re-request a review as soon you finish to address this comment.

@ystknsh ystknsh changed the title add sh file, commands/browsing/open-multiple-websites-on-safari.sh add sh file, commands/browsing/open-multiple-websites-on-safari.template.sh Aug 30, 2024
@ystknsh ystknsh removed their assignment Aug 30, 2024
@ystknsh
Copy link
Contributor Author

ystknsh commented Aug 30, 2024

@unnamedd
Thank you for your review.
I have changed the filename as requested. Could you please check my PR again?

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your change @ystknsh!

It looks good to me!

@unnamedd unnamedd added the accepted PR is ready to be merged label Aug 30, 2024
Copy link
Contributor

@nagauta nagauta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@grzegorzkrukowski grzegorzkrukowski merged commit f3f1961 into raycast:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants