Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script to search notes via title #527

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

vardansawhney
Copy link
Contributor

Description

Simply allows you to search your notes via title.

Note: titles need to be exact matches in order to query them properly and in the event that you have mutliple of the same titles, it'll choose the most recently edited one to display.

Type of change

  • New script command

Screenshot

Screen.Recording.2021-07-28.at.1.15.48.PM.mov

Dependencies / Requirements

No reqs/depedencies required.

Checklist

@RSO
Copy link
Contributor

RSO commented Jul 29, 2021

Thank you for the contribution! Do you know whether it'd be possible to show a more helpful error message in the case that the note can't be found?

It's too bad that it requires the note title to be an exact match, and that there does not seem to be search functionality.

@unnamedd
Copy link
Collaborator

I had the same though as you @RSO! This Script Command may be called "Open Note" instead of "Search Notes".

Thank you for the contribution! Do you know whether it'd be possible to show a more helpful error message in the case that the note can't be found?

It's too bad that it requires the note title to be an exact match, and that there does not seem to be search functionality.

@vardansawhney
Copy link
Contributor Author

Yup for sure! I'll go ahead and add a clear error message for a failed search, and will update the name to be open note as opposed to search note.

@vardansawhney
Copy link
Contributor Author

@unnamedd @RSO

I've gone ahead and added some better error logging, and updated the name to (Open Note as opposed to Search Note)

Screen.Recording.2021-07-30.at.4.32.23.PM.mov

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the changes @commai!

@fe9lix fe9lix merged commit bf09186 into raycast:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants