Skip to content

Enhance iMessage 2FA#3295

Merged
pernielsentikaer merged 3 commits intoraycast:mainfrom
ye4241:main
Oct 24, 2022
Merged

Enhance iMessage 2FA#3295
pernielsentikaer merged 3 commits intoraycast:mainfrom
ye4241:main

Conversation

@ye4241
Copy link
Contributor

@ye4241 ye4241 commented Oct 22, 2022

Description

  1. Add paste code as default action for 2FA.
  2. Add support for Douyin 2FA.

Screencast

Paste Code

Checklist

@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Oct 22, 2022
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 22, 2022

Thank you for your contribution! 🎉

🔔 @yuercl you might want to have a look.

Copy link
Contributor

@yuercl yuercl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty good pr for setting 'Past Code' to default action.

May be better like below if we only change the first match case code length from {5,8} to {4,8}?

if ((m = /(^|\s|\\R|\t|\b|G-|:)(\d{4,8})($|\s|\\R|\t|\b|\.|,)/.exec(message)) !== null) {
    code = m[2];
    // 4-8 consecutive digits
    // examples:
    //   "您的验证码是 199035,10分钟内有效,请勿泄露"
    //   "登录验证码:627823,您正在尝试【登录】,10分钟内有效"
    //   "【赛验】验证码 54538"
    //   "【抖音】验证码9316,用于手机验证"
    //   "Enter this code to log in:59678."
    //   "G-315643 is your Google verification code"
    //   "Enter the code 765432, and then click the button to log in."
    //   "Your code is 45678!"
    //   "Your code is:98765!"
  }

@ye4241

@ye4241
Copy link
Contributor Author

ye4241 commented Oct 24, 2022

@yuercl This will cause many text messages that are not 2fa to become 2fa. eg.

【招商银行】您尾号1234的招行信用卡10月22日00:00消费5000.00人民币。 -> 1234
【华为云】尊敬的xxx:您有1个包年/包月资源于2022/10/22 00:00:00自动续费成功 -> 2022

When I verify {4,8} locally, the error rate is about half. If it's not too much about correct identification, it can be simply changed to {4,8}.

Copy link
Contributor

@yuercl yuercl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enhance this extension for supporting {4,8} digits with Chinese word '码' (code)
@pernielsentikaer

@pernielsentikaer pernielsentikaer merged commit 0e9f4b4 into raycast:main Oct 24, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/yuercl/imessage-2fa

arguiot added a commit to arguiot/raycast-extensions that referenced this pull request Sep 6, 2025
- Update package.json
- Remove card hover animations (raycast#3298)
- Raycast extension V1 (raycast#3238)
- (Part 2) Notification system (raycast#3120)
- Fix cannot access meeting while starting a new meeting (raycast#3246)
- Fix issue with auto-start being triggered when you go to new meeting (raycast#3295)
- Enable commenting on external meetings (raycast#3294)
- Remove command menu divider (raycast#3293)
- Fix for not showing selected screen in record panel (raycast#3290)
- Fix bug with comments not being associated with words (raycast#3291)
- Fix command menu colour in dark mode (raycast#3292)
- Fix for meeting having no attendees/participants (raycast#3279)
- Fix for screen showing at the end (raycast#3287)
- Floating panel component (raycast#3266)
- Update raycast oauth scope (raycast#3289)
- LLM language response prompt update (raycast#3286)
- Fix for not able to update meeting (raycast#3272)
- Fix for screen syncing issue (raycast#3255)
- Fix account disconnects (raycast#3285)
- Delete meeting window detection/notification hook (raycast#3283)
- Only remux for our recordings, don\'t remux recall (raycast#3235)
- ical_uid fix (raycast#3281)
- Fix spacing for last action item (raycast#3280)
- Dedup calendar meetings across different calendars (raycast#3268)
- Do not autostart when recording (raycast#3278)
- Always use inputUri as fileUrl for `detect-language` (raycast#3276)
- Use inputUri as default fileUrl on detect language receiver (raycast#3275)
- Fix missing header in GCS finish upload path (future meetings) (raycast#3264)
- Fix keyboard issues on mobile (raycast#3274)
- Mobile web fixes for multi-select (raycast#3263)
- Exclude device recording meetings from recall check (raycast#3270)
- Update mobile labeler (raycast#3269)
- Update left nav badge (raycast#3256)
- Fix bug with missing attendees in people tab (raycast#3265)
- Moved discard changes to a shared hook (raycast#3262)
- Minor style updates for nested subcommands (raycast#3260)
- Awaiting for router to complete after discarding automation (raycast#3261)
- Add Cmd/Ctrl+N for new meeting (raycast#3257)
- Define relevant attendees before usage (raycast#3259)
- Prorated seat charge comments (raycast#3254)
- Add email sender attribution Posthog events (raycast#3045)
- Preparing for store
- Remove default val for `excludeRecallMeetings` (raycast#3253)
- Onboarding V2: Prompt for calendar access (raycast#3183)
- Schedule team seat update on deactivate/invite/make viewer/etc (raycast#3234)
- Update oauth.ts
- Update search-meetings.tsx
- Remove duplicate maxDuration config (raycast#3250)
- Clean up imports and meeting URL construction
- Fix assistant submit button alignment (raycast#3251)
- Add fire icon and improve Raycast extension text
- Add new db alerts to github actions [1 liner] (raycast#3249)
- Add better DB alerts (raycast#3248)
- Update package.json
- Lint
- Merge branch \'main\' into arthur/raycast
- Connect input field (raycast#3195)
- Fix last unmatched attendee when calendar invitee has diff email (raycast#3240)
- cleanup
- Improved extension
- Merge branch \'arthur/oauth-pkce\' into arthur/raycast
- Update oauth.ts
- [DB Migration] Adds OAuth PKCE authorization flow
- [wip]
- Merge branch \'main\' into arthur/raycast
- setting up OAuth
- [wip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants