-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Update bnf-search-tool extension #25392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update bnf-search-tool extension #25392
Conversation
- add medusa, treatment summaries - Add Search logic and Medusa site shortcut
|
Thank you for the update! 🎉 We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile OverviewGreptile SummaryThis PR adds treatment summary fallback search and Medusa integration to the BNF search extension. When a drug monograph isn't found, the extension now checks for treatment summaries before falling back to general search results. Key changes:
Issues found:
Confidence Score: 2/5
Important Files Changed
Last reviewed commit: 8ee25d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 4 comments
|
|
||
| - Initial release of BNF Search tool. | ||
|
|
||
| ## [Medusa and Treatment Summary search added] - 2026-02-05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must use {PR_MERGE_DATE} placeholder instead of hardcoded date - this is automatically replaced during release
| ## [Medusa and Treatment Summary search added] - 2026-02-05 | |
| ## [Medusa and Treatment Summary search added] - {PR_MERGE_DATE} |
Context Used: Rule from dashboard - What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of th... (source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please look into this?
The format of the changelog entries is not correct and missing the placeholder {PR_MERGE_DATE}
Reference:
… replaced with \'HEAD\' to improve performance.
| "name": "index", | ||
| "title": "Medication Search", | ||
| "subtitle": "BNF / BNFC", | ||
| "title": "BNF and BNFC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: improve command name
can you use Search or View BNF/BNFC instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: metadata image style
The current screenshot has local extension icon in the bottom bar
Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?
Reference:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: metadata image style
The current screenshot has local extension icon in the bottom bar
Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?
Reference:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: metadata image style
The current screenshot has local extension icon in the bottom bar
Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?
Reference:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: remove unnecessary file
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Thanks for your contribution 💪
Could you look into the review comments?
I'm looking forward to reviewing this extension again 🔥
I converted this PR into a draft until it's ready for the review, please press the button Ready for review when it's ready and we'll have a look 😊
Feel free to contact me here or at Slack if you have any questions.
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder