Skip to content

Conversation

@myusualonewastaken
Copy link
Contributor

@myusualonewastaken myusualonewastaken commented Feb 12, 2026

Description

Screencast

Checklist

- add medusa, treatment summaries
- Add Search logic and Medusa site shortcut
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: bnf-search-tool Issues related to the bnf-search-tool extension platform: macOS platform: Windows OP is author The OP of the PR is the author of the extension labels Feb 12, 2026
@raycastbot
Copy link
Collaborator

Thank you for the update! 🎉

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

@myusualonewastaken myusualonewastaken marked this pull request as ready for review February 12, 2026 20:45
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR adds treatment summary fallback search and Medusa integration to the BNF search extension. When a drug monograph isn't found, the extension now checks for treatment summaries before falling back to general search results.

Key changes:

  • Added treatment summary URL fallback between drug lookup and search results
  • Added Medusa link to action panel with Cmd + M shortcut
  • Updated UI labels from "Medication" to "Drug or Condition"
  • Enhanced special character cleaning in slug generation
  • Updated metadata screenshots to reflect new functionality

Issues found:

  • Changed HEAD to GET requests on lines 40 and 49, which downloads full page content unnecessarily instead of just checking page existence - this significantly impacts performance and data usage
  • CHANGELOG.md entry uses hardcoded date 2026-02-05 instead of required {PR_MERGE_DATE} placeholder
  • CHANGELOG.md entry is in wrong order (should be at top of file in descending version order)

Confidence Score: 2/5

  • This PR introduces performance regression and changelog formatting issues that must be resolved before merging
  • Score reflects two critical issues: (1) the HEAD-to-GET change will cause noticeable performance degradation by downloading full HTML pages twice instead of checking headers, and (2) changelog formatting violations that will cause build/release issues
  • Pay close attention to extensions/bnf-search-tool/src/index.tsx (performance regression) and extensions/bnf-search-tool/CHANGELOG.md (formatting violations)

Important Files Changed

Filename Overview
extensions/bnf-search-tool/src/index.tsx Added treatment summary fallback and Medusa link, but changed HEAD to GET requests causing performance degradation
extensions/bnf-search-tool/CHANGELOG.md Added new entry but uses hardcoded date instead of {PR_MERGE_DATE} placeholder and incorrect ordering
extensions/bnf-search-tool/package.json Updated command title and subtitle, no issues found

Last reviewed commit: 8ee25d9

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile


- Initial release of BNF Search tool.

## [Medusa and Treatment Summary search added] - 2026-02-05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must use {PR_MERGE_DATE} placeholder instead of hardcoded date - this is automatically replaced during release

Suggested change
## [Medusa and Treatment Summary search added] - 2026-02-05
## [Medusa and Treatment Summary search added] - {PR_MERGE_DATE}

Context Used: Rule from dashboard - What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of th... (source)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myusualonewastaken

Can you please look into this?

The format of the changelog entries is not correct and missing the placeholder {PR_MERGE_DATE}

Reference:

… replaced with \'HEAD\' to improve performance.
"name": "index",
"title": "Medication Search",
"subtitle": "BNF / BNFC",
"title": "BNF and BNFC",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: improve command name

can you use Search or View BNF/BNFC instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: metadata image style

The current screenshot has local extension icon in the bottom bar

Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?

Reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: metadata image style

The current screenshot has local extension icon in the bottom bar

Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?

Reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: metadata image style

The current screenshot has local extension icon in the bottom bar

Could you make sure that the metadata images use the same background/appearance as the rest to maintain the same visual expression?

Reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: remove unnecessary file

Copy link
Contributor

@0xdhrv 0xdhrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

Could you look into the review comments?

I'm looking forward to reviewing this extension again 🔥

I converted this PR into a draft until it's ready for the review, please press the button Ready for review when it's ready and we'll have a look 😊

Feel free to contact me here or at Slack if you have any questions.

@0xdhrv 0xdhrv self-assigned this Feb 13, 2026
@0xdhrv 0xdhrv marked this pull request as draft February 13, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: bnf-search-tool Issues related to the bnf-search-tool extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants