Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Update jupyter command reference to match #173

Merged

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Feb 9, 2020

I was doing a quick run-through of some of the tutorials, noticed that this references jupyter-lab as the launch command but for me with Python 3.6 and a new virtual environment I got jupyter-notebook. You can see the stream at https://www.youtube.com/watch?v=WBNmF-wyAlE
Thanks for making the tutorials y'all :)

There are also some small whitespaces cleanup changes that my emacs configuration did automatically, I can back them out if folks prefer.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing- looks great to me! From your stream description, it seems like we need to improve our k8s integration experience... suggestions welcome there!

@richardliaw richardliaw merged commit 924b04c into ray-project:master Feb 9, 2020
@holdenk
Copy link
Contributor Author

holdenk commented Feb 9, 2020

Thanks, I was trying to use the release version I’ll play more with master and K8s soon :)

sunstick pushed a commit to sunstick/ray-tutorial that referenced this pull request Sep 7, 2020
* With a pip installed jupyter in py3 I don't get the jupyter-lab command, I get the jupyter-notebook command, jupyter==1.0.0

* 2nd place we assume jupyter-lab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants