Update com_github_nelhage_rules_boost version in ray_deps_setup.bzl #9975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support boost.dll
|
Can one of the admins verify this patch? |
|
Test FAILed. |
raulchen
approved these changes
Aug 7, 2020
raulchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support boost.dll
Why are these changes needed?
cpp-worker need boost.dll to operate the dynamic library, but the current com_github_nelhage_rules_boost does not contain boost.dll.
I made a pr to support boost.dll for nelhage_rules_boost, they have merged the pr(nelhage/rules_boost#187).
So we need to update com_github_nelhage_rules_boost to support boost.dll
Checks
tests passed.