Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] Transformer blog example #9789

Merged
merged 44 commits into from
Aug 5, 2020
Merged

[Tune] Transformer blog example #9789

merged 44 commits into from
Aug 5, 2020

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Jul 29, 2020

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@amogkam amogkam requested a review from richardliaw July 29, 2020 20:26
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

richardliaw
richardliaw reviewed Jul 29, 2020
View reviewed changes
python/ray/tune/examples/README.rst Outdated
@@ -52,6 +52,11 @@ LightGBM Example

- `lightgbm_example <https://github.com/ray-project/ray/blob/master/python/ray/tune/examples/lightgbm_example.py>`__: Trains a basic LightGBM model with Tune with the function-based API and a LightGBM callback.

:hugging_face: Transformers Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work? interesting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it working for the sphinx docs but cant figure out how to do it for Github rst

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29147/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29150/
Test FAILed.

@rkooo567 rkooo567 added the release-blocker P0 Issue that blocks the release label Jul 31, 2020
richardliaw
richardliaw reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks awesome. Can you add a README.rst in pbt_transformers/ so that users can know how to run things and such?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29332/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29317/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29319/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29348/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29390/
Test FAILed.

richardliaw
richardliaw reviewed Aug 4, 2020
View reviewed changes
python/ray/tune/examples/pbt_transformers/pbt_transformers.py Outdated
os.mkdir(data_dir, 0o755)

# Change these as needed.
model_name = "bert-base-uncased"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for smoke-test can we actually use a super tiny model?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29412/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29420/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/29422/
Test FAILed.

@richardliaw richardliaw merged commit 5af7d24 into ray-project:master Aug 5, 2020
rkooo567 pushed a commit that referenced this pull request Aug 6, 2020
@amogkam @rkooo567
[Tune] Transformer blog example (#9789)
92e0718 
Co-authored-by: Kai Fricke <kai@anyscale.com>
@amogkam amogkam deleted the tune-transformer-blog-example branch October 2, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amogkam @AmplabJenkins @richardliaw @rkooo567