Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix MetricTest.java due to incomplete changes from #9703 #9770

Merged
merged 2 commits into from
Jul 29, 2020
Merged

[Java] Fix MetricTest.java due to incomplete changes from #9703 #9770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1334fe
Fix MetricTest.java
kfstorm Jul 29, 2020
51203d4
Remove @Test annotations
kfstorm Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions java/test/src/main/java/io/ray/test/MetricTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@ public void testAddHistogram() {
Assert.assertEquals(window.size(), 0);
}

@Test
public void testRegisterGauge() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
Gauge gauge = registerGauge();

gauge.update(2.0);
Expand All @@ -147,9 +145,7 @@ public void testRegisterGauge() throws InterruptedException {
Assert.assertTrue(doubleEqual(gauge.getValue(), 5.0));
}

@Test
public void testRegisterCount() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
Count count = registerCount();

count.inc(10.0);
Expand All @@ -160,9 +156,7 @@ public void testRegisterCount() throws InterruptedException {
Assert.assertTrue(doubleEqual(count.getCount(), 33.0));
}

@Test
public void testRegisterSum() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
Sum sum = registerSum();

sum.update(10.0);
Expand All @@ -173,9 +167,7 @@ public void testRegisterSum() throws InterruptedException {
Assert.assertTrue(doubleEqual(sum.getSum(), 33.0));
}

@Test
public void testRegisterHistogram() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
Histogram histogram = registerHistogram();

for (int i = 1; i <= 200; ++i) {
Expand All @@ -189,9 +181,7 @@ public void testRegisterHistogram() throws InterruptedException {
Assert.assertTrue(doubleEqual(histogram.getValue(), 200.0d));
}

@Test
public void testRegisterGaugeWithConfig() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
initRayMetrics(2000L, 1, 1000L);
Gauge gauge = registerGauge();

Expand All @@ -201,9 +191,7 @@ public void testRegisterGaugeWithConfig() throws InterruptedException {
Assert.assertTrue(doubleEqual(gauge.getValue(), 5.0));
}

@Test
public void testRegisterCountWithConfig() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
initRayMetrics(2000L, 1, 1000L);
Count count = registerCount();

Expand All @@ -215,9 +203,7 @@ public void testRegisterCountWithConfig() throws InterruptedException {
Assert.assertTrue(doubleEqual(count.getCount(), 33.0));
}

@Test
public void testRegisterSumWithConfig() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
initRayMetrics(2000L, 1, 1000L);
Sum sum = registerSum();

Expand All @@ -229,9 +215,7 @@ public void testRegisterSumWithConfig() throws InterruptedException {
Assert.assertTrue(doubleEqual(sum.getSum(), 33.0));
}

@Test
public void testRegisterHistogramWithConfig() throws InterruptedException {
TestUtils.skipTestUnderSingleProcess();
initRayMetrics(2000L, 1, 1000L);
Histogram histogram = registerHistogram();

Expand Down