Skip to content

[GCS]Open test_gcs_fault_tolerance testcase #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2020
Merged

[GCS]Open test_gcs_fault_tolerance testcase #9677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23d2680
enable test_gcs_fault_tolerance
Jul 24, 2020
8db52ab
fix lint error
Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/ray/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,8 +468,7 @@ py_test(
name = "test_gcs_fault_tolerance",
size = "medium",
srcs = SRCS + ["test_gcs_fault_tolerance.py"],
# TODO(swang): Enable again once pubsub client supports GCS server restart.
tags = ["exclusive", "manual"],
tags = ["exclusive"],
deps = ["//:ray_lib"],
)

Expand Down
10 changes: 10 additions & 0 deletions python/ray/tests/test_gcs_fault_tolerance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import sys

import ray
Expand All @@ -20,6 +21,9 @@ def increase(x):
return x + 1


@pytest.mark.skipif(
os.environ.get("RAY_GCS_ACTOR_SERVICE_ENABLED") != "true",
reason=("This testcase can only be run when GCS actor management is on."))
def test_gcs_server_restart(ray_start_regular):
actor1 = Increase.remote()
result = ray.get(actor1.method.remote(1))
Expand All @@ -39,6 +43,9 @@ def test_gcs_server_restart(ray_start_regular):
assert result == 2


@pytest.mark.skipif(
os.environ.get("RAY_GCS_ACTOR_SERVICE_ENABLED") != "true",
reason=("This testcase can only be run when GCS actor management is on."))
def test_gcs_server_restart_during_actor_creation(ray_start_regular):
ids = []
for i in range(0, 100):
Expand All @@ -54,6 +61,9 @@ def test_gcs_server_restart_during_actor_creation(ray_start_regular):
assert len(unready) == 0


@pytest.mark.skipif(
os.environ.get("RAY_GCS_ACTOR_SERVICE_ENABLED") != "true",
reason=("This testcase can only be run when GCS actor management is on."))
@pytest.mark.parametrize(
"ray_start_cluster_head",
[generate_internal_config_map(num_heartbeats_timeout=20)],
Expand Down