Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change error code name of boost timer #9417

Merged
merged 2 commits into from
Jul 14, 2020
Merged

change error code name of boost timer #9417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa6db06
change error code name of boost timer
kisuke95 Jul 11, 2020
814dc86
modify comments
kisuke95 Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
modify comments
  • Loading branch information
@kisuke95
kisuke95 committed Jul 12, 2020
commit 814dc86adec9661f8e51a9121c34d889442fee57
2 changes: 1 addition & 1 deletion src/ray/gcs/gcs_client/service_based_gcs_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ void ServiceBasedGcsClient::PeriodicallyCheckGcsServerAddress() {
detect_timer_->expires_from_now(check_period);
detect_timer_->async_wait([this](const boost::system::error_code &error) {
if (error == boost::asio::error::operation_aborted) {
// `operation_canceled` is set when `detect_timer_` is canceled or destroyed.
// `operation_aborted` is set when `detect_timer_` is canceled or destroyed.
return;
}
RAY_CHECK(!error) << "Checking gcs server address failed with error: "
Expand Down
2 changes: 1 addition & 1 deletion src/ray/gcs/gcs_server/gcs_node_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void GcsNodeManager::NodeFailureDetector::ScheduleTick() {
detect_timer_.expires_from_now(heartbeat_period);
detect_timer_.async_wait([this](const boost::system::error_code &error) {
if (error == boost::asio::error::operation_aborted) {
// `operation_canceled` is set when `detect_timer_` is canceled or destroyed.
// `operation_aborted` is set when `detect_timer_` is canceled or destroyed.
// The Monitor lifetime may be short than the object who use it. (e.g. gcs_server)
return;
}
Expand Down