Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split hiredis from Redis and use it directly #9176

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Split hiredis from Redis and use it directly #9176

merged 2 commits into from
Jun 30, 2020

Conversation

mehrdadn
Copy link
Contributor

Why are these changes needed?

The upstream hiredis repo is separate from that of Redis, and it has been updated with various Windows patches recently.

We can't pull in the Windows patches quite yet, but this PR switches to that repo to allow us to update them independently in the future.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27628/
Test PASSed.

@simon-mo
Copy link
Contributor

We can't pull in the Windows patches quite yet

why?

simon-mo
simon-mo reviewed Jun 29, 2020
View reviewed changes
bazel/BUILD.hiredis
Comment on lines +30 to +31
"*.h",
"adapters/*.h",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**/*.h wildcards?

Copy link
Contributor Author

@mehrdadn mehrdadn Jun 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would pull in the examples/ directory which we don't want. (Unless you mean I should use exclude?)

bazel/BUILD.hiredis Outdated
Comment on lines 8 to 9

cc_library(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment why this is needed? (vs. directly merge it to cc_library(name = "hiredis"...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I thought I kept the note for this, thanks for catching!

@mehrdadn
Copy link
Contributor Author

mehrdadn commented Jun 29, 2020 •
edited
Loading

@simon-mo We can't pull them because they're incompatible with some of the patches on our side and I haven't managed to find a way to get them working on Windows so far (whether with or without our patches).

@suquark suquark merged commit 79c4c67 into ray-project:master Jun 30, 2020
@mehrdadn mehrdadn deleted the hiredis-split branch June 30, 2020 01:16
@mehrdadn mehrdadn mentioned this pull request Jul 3, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@suquark suquark suquark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mehrdadn @AmplabJenkins @simon-mo @suquark @web-flow