Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] New dashboard skeleton #9099
[Dashboard] New dashboard skeleton #9099
Changes from 12 commits
4bd24e1
c1518f3
6bae695
21b1cea
4c653d4
2de975c
d8afdd3
87a7b8c
52460a3
aae9e9e
9cb1a3c
8e0a1be
5cd38c3
d956703
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need object store name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the job module to start the driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. We were planning to wait to merge the jobs portion of the new dashboard code until we get approval from Robert and the like to add jobs. I'm not sure what the latest status is there, but I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep this argument in order to share the same code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create_task
is available after python 3.7. https://docs.python.org/3/library/asyncio-task.html#asyncio.create_taskCan you use Python 3.5 compatible API? I believe it was
ensure_future
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method
asyncio.loop.create_task
is available in Python 3.5. Please refer to: https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.create_taskThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set it to 1 second? We'd like to make it real time. It'll be also great if this value is configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I will make the values configurable in the future. Here are two ways:
env_integer
inray_constants.py
.I prefer the first one, It's cleaner but not easy to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first one is fine. It'll be pretty easy to iterate or upgrade if necessary.