Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Add microbenchmark script #8887

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Jun 10, 2020

Why are these changes needed?

Need some basic microbenchmarks to run to track performance. Results from my laptop below - there's work to be done!

{'max_batch_size': 1, 'max_concurrent_queries': 1, 'num_replicas': 1}:
        single client small data 274.79 +- 26.16 requests/s
        8 clients small data 659.81 +- 20.8 requests/s
{'max_batch_size': 1, 'max_concurrent_queries': 10000, 'num_replicas': 1}:
        single client small data 304.6 +- 16.72 requests/s
        8 clients small data 945.01 +- 37.91 requests/s
{'max_batch_size': 10000, 'max_concurrent_queries': 10000, 'num_replicas': 1}:
        single client small data 289.04 +- 10.51 requests/s
        8 clients small data 968.28 +- 23.14 requests/s
{'max_batch_size': 1, 'max_concurrent_queries': 1, 'num_replicas': 8}:
        single client small data 271.3 +- 4.97 requests/s
        8 clients small data 901.81 +- 27.54 requests/s
{'max_batch_size': 1, 'max_concurrent_queries': 10000, 'num_replicas': 8}:
        single client small data 255.21 +- 15.2 requests/s
        8 clients small data 931.31 +- 32.58 requests/s
{'max_batch_size': 10000, 'max_concurrent_queries': 10000, 'num_replicas': 8}:
        single client small data 279.18 +- 4.45 requests/s
        8 clients small data 918.58 +- 74.42 requests/s

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor

can you move https://github.com/ray-project/ray/blob/master/python/ray/serve/examples/benchmark.py to the same directory and name it latency benchmark?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26998/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26995/
Test PASSed.

@edoakes edoakes merged commit 527b038 into ray-project:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants