-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Require backend when creating endpoint #8764
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
Test PASSed. |
Why are these changes needed?
Currently you can create and endpoint with no backends. This is a footgun for users and doesn't make conceptual sense. This change forces users to specify an existing backend when creating an endpoint to service the traffic. This also prevents users who only use a single backend from having to think about the
set_traffic
API.Checks
scripts/format.sh
to lint the changes in this PR.