[gcs] add missing templated log classes #8690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Can one of the admins verify this patch? |
acxz
changed the title
|
Test PASSed. |
ffbin
reviewed
Jun 1, 2020
| @@ -870,6 +870,9 @@ template class Log<JobID, ErrorTableData>; | |||
| template class Log<ClientID, GcsNodeInfo>; | |||
| template class Log<JobID, JobTableData>; | |||
| template class Log<UniqueID, ProfileTableData>; | |||
| template class Log<ClientID, HeartbeatTableData>; | |||
There was a problem hiding this comment.
HeartbeatTable is inherit from Table<ClientID, HeartbeatTableData>, why add Log<ClientID, HeartbeatTableData>?
There was a problem hiding this comment.
HeartbeatTable may be inherited, but the associated Log<...> class needs to be instantiated since it is a template. If it is not then Log<ClientID, HeartbeatTableData> is not seen as a class further down resulting in the following error:
bazel-out/k8-opt/bin/_objs/gcs/subscription_executor.pic.o:subscription_executor.cc:function ray::gcs::SubscriptionExecutor<ray::ClientID, ray::rpc::HeartbeatTableData, ray::gcs::HeartbeatTable>::AsyncSubscribeAll(ray::ClientID const&, std::function<void (ray::ClientID const&, ray::rpc::HeartbeatTableData const&)> const&, std::function<void (ray::Status)> const&): error: undefined reference to 'ray::gcs::Log<ray::ClientID, ray::rpc::HeartbeatTableData>::Subscribe(ray::JobID const&, ray::ClientID const&, std::function<void (ray::gcs::RedisGcsClient*, ray::ClientID const&, std::vector<ray::rpc::HeartbeatTableData, std::allocator<ray::rpc::HeartbeatTableData> > const&)> const&, std::function<void (ray::gcs::RedisGcsClient*)> const&)'
collect2: error: ld returned 1 exit status
Just tested it with and without the line in question.
ffbin
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently with the latest ray version, 0.8.5, it is not possible to build from source. (Tested on Arch Linux). This PR adds the relevant missing templated log classes to remove the undefined symbol errors.
Related issue number
Closes #853
Checks
scripts/format.shto lint the changes in this PR.Above checks do not apply since this is a built PR, besides waiting for CI tests.