You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When lineage reconstruction is enabled, Ray will attempt to recreate objects that were stored in plasma and lost due to a failure through task re-execution. However, this will not work if the task depends on an object created by ray.put, since the caller would also have to be restarted.
This PR pins objects that are created by ray.put so that they will not be evicted until all downstream tasks can not be executed again. This guarantees that the object value will be available if lineage reconstruction is needed.
Checks
I've run scripts/format.sh to lint the changes in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When lineage reconstruction is enabled, Ray will attempt to recreate objects that were stored in plasma and lost due to a failure through task re-execution. However, this will not work if the task depends on an object created by
ray.put, since the caller would also have to be restarted.This PR pins objects that are created by
ray.putso that they will not be evicted until all downstream tasks can not be executed again. This guarantees that the object value will be available if lineage reconstruction is needed.Checks
scripts/format.shto lint the changes in this PR.