Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Add pytorch sigils to toc and add links to algo overview table. #7950

Merged
merged 2 commits into from
Apr 9, 2020
Merged

[RLlib] Add pytorch sigils to toc and add links to algo overview table. #7950

merged 2 commits into from
Apr 9, 2020

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 9, 2020 •
edited
Loading

Adds pytorch sigils to toc (DQN and APEX) and adds links to algo overview table.

Related issue number

Checks

@sven1977 sven1977 requested a review from ericl April 9, 2020 06:13
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24435/
Test PASSed.

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Apr 9, 2020
@sven1977
Copy link
Contributor Author

sven1977 commented Apr 9, 2020

@ericl Please merge. Tests are ok (except for the seemingly broken test_io one).

@ericl ericl merged commit d2b5c17 into ray-project:master Apr 9, 2020
wuisawesome pushed a commit to wuisawesome/ray that referenced this pull request Apr 13, 2020
@sven1977 @wuisawesome
[RLlib] Add pytorch sigils to toc and add links to algo overview tabl…
131f9a3 
…e. (ray-project#7950)

* Add torch sigils to toc-tree for DQN/APEX.

* WIP.
@sven1977 sven1977 deleted the add_pytorch_sigils_to_toc branch August 21, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @AmplabJenkins @ericl